[tarantool-patches] Re: [PATCH 2/4] Fix creation of FK constraint in case of no child's PK

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Apr 1 16:41:53 MSK 2019


Hi! Thanks for the patch!

I've made a tiny fix and force merged it into
the commit.

After that the patchset LGTM.

=============================================

diff --git a/test/sql/foreign-keys.result b/test/sql/foreign-keys.result
index 97c3e2442..d69f93a9c 100644
--- a/test/sql/foreign-keys.result
+++ b/test/sql/foreign-keys.result
@@ -387,10 +387,7 @@ box.space.T4:drop()
 ...
 -- Make sure that child space can feature no PK.
 --
-t1 = box.schema.create_space("T1")
----
-...
-box.space.T1:format({'ID'})
+t1 = box.schema.create_space("T1", {format = {'ID'}})
 ---
 ...
 t2 = box.schema.create_space("T2")
diff --git a/test/sql/foreign-keys.test.lua b/test/sql/foreign-keys.test.lua
index 078c10c54..4ddf5e83b 100644
--- a/test/sql/foreign-keys.test.lua
+++ b/test/sql/foreign-keys.test.lua
@@ -176,8 +176,7 @@ box.space.T4:drop()
 
 -- Make sure that child space can feature no PK.
 --
-t1 = box.schema.create_space("T1")
-box.space.T1:format({'ID'})
+t1 = box.schema.create_space("T1", {format = {'ID'}})
 t2 = box.schema.create_space("T2")
 i1 = box.space.T2:create_index('I1')
 box.sql.execute("ALTER TABLE t1 ADD CONSTRAINT fk FOREIGN KEY (id) REFERENCES t2;")




More information about the Tarantool-patches mailing list