[tarantool-patches] Re: [PATCH v1 1/1] sql: parameter binding for box.execute()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Apr 1 16:44:03 MSK 2019


Separate patch would ruin the git history. I would
rather fix this and box.sql.execute removal patchsets
to keep the history clean.

On 01/04/2019 16:05, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/01 11:45]:
>>
>>
>> On 01/04/2019 08:21, Konstantin Osipov wrote:
>>> * imeevma at tarantool.org <imeevma at tarantool.org> [19/03/30 16:50]:
>>>> This patch defines parameters binding for SQL statements executed
>>>> through box.execute().
>>>
>>> Could the dependency on lua_* be moved into src/box/lua/ or that
>>> would be difficult to do?
>>
>> It requires exposure of struct sql_bind into the header file, and
>> include "execute.h" into one of box/lua files. If you insist, we
>> can do that. Should we?
> 
> Yes, in a separate patch.
> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 




More information about the Tarantool-patches mailing list