[tarantool-patches] Re: [PATCH v8 3/3] sql: remove psql_txn from Vdbe

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Oct 30 22:41:47 MSK 2018

Thanks for the review!

On 30/10/2018 17:30, n.pettik wrote:
>> It makes no sense to store it here, and it has never
>> did.
> Nit: this sentence is grammatically incorrect, I guess.

Sorry, just typo. I removed the second part of the
sentence. Look at the branch.

>> SQL transaction specific things shall be taken
>> from global txn object, as any transaction specific
>> things.
> Patch itself is OK, but I would either separate this patch from patch-set,
> or add "Follow up #xxxx” sign.

Done. I used 'follow up'.

More information about the Tarantool-patches mailing list