[tarantool-patches] Re: [PATCH v8 3/3] sql: remove psql_txn from Vdbe

n.pettik korablev at tarantool.org
Tue Oct 30 17:30:29 MSK 2018

> It makes no sense to store it here, and it has never
> did.

Nit: this sentence is grammatically incorrect, I guess.

> SQL transaction specific things shall be taken
> from global txn object, as any transaction specific
> things.
> ---
> Issue: https://github.com/tarantool/tarantool/issues/2618
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-2618-return-all-generated-ids

You don’t need to put links to branch/issue to each patch of patch-set -
you should do it only for covering letter.

Patch itself is OK, but I would either separate this patch from patch-set,
or add "Follow up #xxxx” sign.

More information about the Tarantool-patches mailing list