[tarantool-patches] Re: [PATCH 2/3] vinyl: account disk statements of each type

Konstantin Osipov kostja at tarantool.org
Tue Oct 23 11:58:45 MSK 2018

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/20 23:19]:
> This patch adds a new entry to per index statistics reported by
> index.stat():
>   disk.statement
>     inserts
>     replaces
>     deletes
>     upserts
> It shows the number of statements of each type stored in run files.
> The new statistics are persisted in index files. We will need this
> information so that we can force major compaction when there are too
> many DELETE statements accumulated in run files.
> Needed for #3225

Please add a documentation request to the changeset comment and
ensure there is a doc ticket - docbot had uptime issues recently.

Moreover, it turned out a number of features were not filed for
documentation in 1.10 release, I believe we need to ban external
behaviour changes in "internal" patches - any patch which changes
the server api should be assigned to an own ticket.

The patch itself is OK to push. 

Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

More information about the Tarantool-patches mailing list