[tarantool-patches] Re: [PATCH 2/3] vinyl: account disk statements of each type

Vladimir Davydov vdavydov.dev at gmail.com
Wed Oct 24 14:19:58 MSK 2018


On Tue, Oct 23, 2018 at 11:58:45AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/20 23:19]:
> > This patch adds a new entry to per index statistics reported by
> > index.stat():
> > 
> >   disk.statement
> >     inserts
> >     replaces
> >     deletes
> >     upserts
> > 
> > It shows the number of statements of each type stored in run files.
> > The new statistics are persisted in index files. We will need this
> > information so that we can force major compaction when there are too
> > many DELETE statements accumulated in run files.
> > 
> > Needed for #3225
> 
> Please add a documentation request to the changeset comment and
> ensure there is a doc ticket - docbot had uptime issues recently.
> 
> Moreover, it turned out a number of features were not filed for
> documentation in 1.10 release, I believe we need to ban external
> behaviour changes in "internal" patches - any patch which changes
> the server api should be assigned to an own ticket.
> 
> The patch itself is OK to push. 

Pushed to 1.10-features and opened a doc ticket:

https://github.com/tarantool/doc/issues/645



More information about the Tarantool-patches mailing list