[tarantool-patches] Re: [PATCH v5 04/12] box: introduce tuple_format_add_key_part

Kirill Shcherbatov kshcherbatov at tarantool.org
Tue Nov 6 15:15:02 MSK 2018


> The patch is OK to push but I object to the name.
> 
> A format doesn't contain key parts. A key def contains key part. A
> format is consistent with key parts. 
> 
> tuple_format_update_with_key_part() perhaps?
> tuple_format_combine_with_key_part()?
> tuple_format_mix_in_key_part()?
> tuple_format_use_key_part()?

Ok, I'd like to use tuple_format_use_key_part routine name.



More information about the Tarantool-patches mailing list