[tarantool-patches] [PATCH v5 04/12] box: introduce tuple_format_add_key_part

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [18/10/29 20:25]:
> Introduced a new tuple_format_add_key_part that makes format
> initialization for specified key_part and configuration.
> This decrease tuple_format_create routine complexity and would
> be used to initialize structures in format for JSON path.

The patch is OK to push but I object to the name.

A format doesn't contain key parts. A key def contains key part. A
format is consistent with key parts. 

tuple_format_update_with_key_part() perhaps?
tuple_format_combine_with_key_part()?
tuple_format_mix_in_key_part()?
tuple_format_use_key_part()?
-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov