[tarantool-patches] Re: [PATCH v7 6/7] sql: export funcs defined on Expr, ExprList to sql.h
Kirill Shcherbatov
kshcherbatov at tarantool.org
Mon May 28 17:59:35 MSK 2018
>> 1. Please, do not put extra white space after *.
> 2. Still not fixed.
diff --git a/src/box/sql.h b/src/box/sql.h
index a02d156..c4d76a7 100644
--- a/src/box/sql.h
+++ b/src/box/sql.h
@@ -191,7 +191,7 @@ sql_table_def_rebuild(struct sqlite3 *db, struct Table *table);
* @retval not NULL on success.
*/
struct ExprList *
-sql_expr_list_dup(struct sqlite3 *db, struct ExprList * p, int flags);
+sql_expr_list_dup(struct sqlite3 *db, struct ExprList *p, int flags);
/**
* Free AST pointed by expr list.
diff --git a/src/box/sql/expr.c b/src/box/sql/expr.c
index cc3278b..d8c6c87 100644
--- a/src/box/sql/expr.c
+++ b/src/box/sql/expr.c
@@ -1447,7 +1447,7 @@ sqlite3ExprDup(sqlite3 * db, Expr * p, int flags)
}
struct ExprList *
-sql_expr_list_dup(struct sqlite3 * db, struct ExprList *p, int flags)
+sql_expr_list_dup(struct sqlite3 *db, struct ExprList *p, int flags)
{
struct ExprList_item *pItem, *pOldItem;
int i;
> 3. Why did you ignore part of comment 7 from the previous review?
-sql_expr_list_append(struct sqlite3 * db, struct ExprList *expr_list,
+sql_expr_list_append(struct sqlite3 *db, struct ExprList *expr_list,
struct Expr *expr)
More information about the Tarantool-patches
mailing list