[tarantool-patches] Re: [PATCH v7 6/7] sql: export funcs defined on Expr, ExprList to sql.h

[Kirill Shcherbatov]

> Why do we need to use low-level parser calls in the server?This functions are required to work with ExprList structure in next commit, 
to duplicate ExprList with checks in space_def_new,  space_def_dup;
to delete them in space_opts_destroy and on checks_array_decode failure; finally, 
to grow checks list width on checks_array_decode iteration.  

I did not want to mix cosmetic and functional changes in one patch.


> I don't understand why we need to use internal parser API calls in
> the server. It seems all the server should need to know is how to
> invoke the parser with a string fragment, and how to convert the
> resulting AST to vdbe, and then how to execute the vdbe/free the
> resources. 
> 
> Perhaps there should be a method to reset the vdbe for subsequent
> execution.
They do not generate Vdbe instructions, it's a service instruments like sql_expr_delete
that already declared in sql.h this way.