[tarantool-patches] Re: [PATCH v3] Fix warnings

[Alexander Turenko]

Hi Gleb,

I have one comment, see below.

WBR, Alexander Turenko.

On Fri, Apr 27, 2018 at 12:53:38PM +0300, Redacted sender "gleb-skiba" for DMARC wrote:
> From: Gleb <gleb-skiba at mail.ru>
> 
> Ensure -Werror -Wall set for the whole src/.
> Fix warnings which have been found with -Werror and -Wall.
> Add new build target RelWithDebInfoWError.
> Change build target on RelWithDebInfoWError in CI.
> 
> Fixes #3238
> ---
> Issue from https://github.com/tarantool/tarantool/issues/3238.
> Source from https://github.com/tarantool/tarantool/tree/gh-3238-check-warnings.
> Changes in v3:
>  -add MAYBE_UNUSED

> diff --git a/src/box/sql/alter.c b/src/box/sql/alter.c
> index b30a973..a83beea 100644
> --- a/src/box/sql/alter.c
> +++ b/src/box/sql/alter.c
> @@ -149,7 +149,7 @@ sqlite3AlterFinishAddColumn(Parse * pParse, Token * pColDef)
>  	Column *pCol;		/* The new column */
>  	Expr *pDflt;		/* Default value for the new column */
>  	sqlite3 *db;		/* The database connection; */
> -	Vdbe *v = pParse->pVdbe;	/* The prepared statement under construction */
> +	MAYBE_UNUSED Vdbe *v = pParse->pVdbe;	/* The prepared statement under construction */
>  	struct session *user_session = current_session();
>  
>  	db = pParse->db;

Too long line (more than 80 symbols).