[tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE

[Vladislav Shpilevoy]

Hello. My congratulations on your first contribution!

The patch is almost perfect with 2 minor comments:

1. Please, in the commit title write a Tarantool submodule prefix. For example,
your patch is about SQL, so you would write 'sql: ' prefix.

On 06/05/2018 01:34, Roman Khabibov wrote:
> Added tests for removed SQL functions "CREATE TEMP TABLE" and "CREATE
> TEMPORARY". There is exeptions, when these functions are used. Tests catch its.
> 
> Closes #2166
> ---
>   test/sql-tap/table.test.lua | 20 +++++++++++++++++++-
>   1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
> index 6e10561..4882b18 100755
> --- a/test/sql-tap/table.test.lua
> +++ b/test/sql-tap/table.test.lua
> @@ -1,6 +1,6 @@
>   #!/usr/bin/env tarantool
>   test = require("sqltester")
> -test:plan(56)
> +test:plan(58)
>   
>   --!./tcltestrunner.lua
>   -- 2001 September 15
> @@ -611,6 +611,24 @@ test:do_execsql2_test(
>   --     SELECT * FROM [t4"abc];
>   --   }
>   -- } {cnt 1 max(b+c) 5}

2. Before the test cases write in comments what do you test here, and
write a link to the issue in the format 'gh-NNNN: description'.
Example: https://github.com/tarantool/tarantool/blob/2.0/test/sql/iproto.test.lua#L122

> +test:do_catchsql_test(
> +	"temp",
> +	[[
> +		CREATE TEMP TABLE
> +	]], {
> +	-- <temp>
> +	1, "near \"TEMP\": syntax error"
> +	-- <temp>
> +	})
> +test:do_catchsql_test(
> +	"temporary",
> +	[[
> +		CREATE TEMPORARY TABLE
> +	]], {
> +	-- <temporary>
> +	1, "near \"TEMPORARY\": syntax error"
> +	-- <temporary>
> +	})
>   test:do_execsql2_test(
>       "table-8.6",
>       [[
>