[tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE

n.pettik korablev at tarantool.org
Tue May 8 13:30:38 MSK 2018


 Hello, Roman.

Firstly, please specify subject of commit. In your particular case,
test definitely belongs to SQL part of project, so it is better to write
'sql: Tests for CREATE TEMP TABLE and  CREATE TEMPORARY TABLE'.
Notice, that commit subject should fit into 50 chars lenght.
Read this guide: https://tarantool.io/en/doc/2.0/dev_guide/developer_guidelines.html#how-to-write-a-commit-message

Secondly, after '---' delimiter (which separates commit message and
body of the patch) put link to your branch and corresponding issue.
Read this: https://tarantool.io/en/doc/2.0/dev_guide/developer_guidelines.html#how-to-submit-a-patch-for-review

Then, don't spam with commits. If you are willing to update your remote
branch with new version of the same code, use 'force' option:
git push -f. As for your patch, it must consist of only 1 commit.
Please, update your branch so than I can take a loot at whole patch.

>+-- gh-2166 Functions with TEMP and TEMPORARY was removed before.

Typo: ‘were’. And not functions, but tables themselves, I guess.





More information about the Tarantool-patches mailing list