[patches] [PATCH 6/7] iproto: send SQL column meta on SELECT

[v.shpilevoy at tarantool.org]

>> +static inline int
>> +sql_ephemeral_column_meta_encode(struct obuf *out,
>> +				 const struct sql_column_meta *column)
> I think reference to artificial column as `ephemeral` is confusing,
> since we recently introduced ephemeral spaces. Maybe use other word?

Maybe. I am open for proposals.

> 
>> +static inline int
>> +sql_table_column_meta_encode(struct obuf *out,
>> +			     const struct sql_column_meta *column)
>> +{
>> +	assert(column->alias != NULL);
>> +	assert(column->name != NULL);
>> +	int alias_len = strlen(column->alias);
>> +	int name_len = strlen(column->name);
>> +	bool is_alias_eq_name =
>> +		alias_len == name_len &&
>> +		memcmp(column->name, column->alias, name_len) == 0;
>> +	struct iproto_sql_column_meta_bin header = iproto_sql_column_meta_bin;
>> +	size_t size = sizeof(header) + mp_sizeof_uint(IPROTO_FIELD_COLUMN) +
>> +		      mp_sizeof_str(name_len);
>> +	if (! is_alias_eq_name) {
>> +		size += mp_sizeof_uint(IPROTO_FIELD_NAME) +
>> +			mp_sizeof_str(alias_len);
>> +		/* @Sa mp_encode_map(). */
> I might be out of context, but what is @Sa?

https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdsa

> 
> --
> Regard, Kirill Yukhin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180301/230c9b19/attachment.html>