[patches] [PATCH 6/7] iproto: send SQL column meta on SELECT

[Kirill Yukhin]

On 01 мар 11:32, v.shpilevoy at tarantool.org wrote:
> 
> >> +static inline int
> >> +sql_ephemeral_column_meta_encode(struct obuf *out,
> >> +				 const struct sql_column_meta *column)
> > I think reference to artificial column as `ephemeral` is confusing,
> > since we recently introduced ephemeral spaces. Maybe use other word?
> 
> Maybe. I am open for proposals.
Artificial? Derived? Calculated?

M$ SQL calls this derived.

> 
> > 
> >> +static inline int
> >> +sql_table_column_meta_encode(struct obuf *out,
> >> +			     const struct sql_column_meta *column)
> >> +{
> >> +	assert(column->alias != NULL);
> >> +	assert(column->name != NULL);
> >> +	int alias_len = strlen(column->alias);
> >> +	int name_len = strlen(column->name);
> >> +	bool is_alias_eq_name =
> >> +		alias_len == name_len &&
> >> +		memcmp(column->name, column->alias, name_len) == 0;
> >> +	struct iproto_sql_column_meta_bin header = iproto_sql_column_meta_bin;
> >> +	size_t size = sizeof(header) + mp_sizeof_uint(IPROTO_FIELD_COLUMN) +
> >> +		      mp_sizeof_str(name_len);
> >> +	if (! is_alias_eq_name) {
> >> +		size += mp_sizeof_uint(IPROTO_FIELD_NAME) +
> >> +			mp_sizeof_str(alias_len);
> >> +		/* @Sa mp_encode_map(). */
> > I might be out of context, but what is @Sa?
> 
> https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdsa
Thx.

> 
> > 
> > --
> > Regard, Kirill Yukhin
>