[patches] [PATCH V2] sql: remove unnecessary SCopy opcodes

[n.pettik]

Hello. See two minor remarks.

> On 12 Mar 2018, at 13:09, Bulat Niatshin <niatshin at tarantool.org> wrote:
> 
> Since OP_NoConflict opcode appears in INSERT/UPDATE VDBE listings
> only when UNIQUE constraint check can't be handled by Tarantool
> (after pushing 2255 to 2.0), related OP_SCopy should appear in
> VDBE listing only when OP_NoConflict is present. This patch
> contains a small fix for that.
> 
> Fix for #2255.

Don’t put dot at the end of footer.
See examples at:
https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-write-a-commit-message <https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-write-a-commit-message>


> 
> +				/* OP_SCopy copies value in separate register,
> +				 * which lately will be used by OP_NoConflict.

“Lately" is an adverb, which means "recently; not long ago”.
I suppose you should use “later”.

The rest is OK.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180312/70364241/attachment.html>