<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hello. See two minor remarks.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 12 Mar 2018, at 13:09, Bulat Niatshin <<a href="mailto:niatshin@tarantool.org" class="">niatshin@tarantool.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Since OP_NoConflict opcode appears in INSERT/UPDATE VDBE listings<br class="">only when UNIQUE constraint check can't be handled by Tarantool<br class="">(after pushing 2255 to 2.0), related OP_SCopy should appear in<br class="">VDBE listing only when OP_NoConflict is present. This patch<br class="">contains a small fix for that.<br class=""><br class="">Fix for #2255.<br class=""></div></div></blockquote><div><br class=""></div>Don’t put dot at the end of footer.</div><div>See examples at:</div><div><a href="https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-write-a-commit-message" class="">https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-write-a-commit-message</a><br class=""><div><br class=""></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div class=""><br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* OP_SCopy copies value in separate register,<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> * which lately will be used by OP_NoConflict.<br class=""></div></div></blockquote></div><br class=""><div style="orphans: 2; widows: 2;" class="">“Lately" is an adverb, which means "<span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#222222" face="arial, sans-serif" size="2" class="">recently; not long ago”.</font></span></div><div class="">I suppose you should use “later”.</div><div class=""><br class=""></div><div class="">The rest is OK.</div></div></body></html>