[tarantool-patches] Re: [PATCH] sql: remove unnecessary def rebuild in endTable()

[Kirill Yukhin]

Hello,
On 07 июн 15:31, Vladislav Shpilevoy wrote:
> Thanks for the patch! LGTM.
> 
> On 07/06/2018 14:24, Nikita Pettik wrote:
> > sqlite3EndTable() routine is called twice during table creation: firsly
> > after initial parsing alongside with generating VDBE program; secondly -
> > as a callback in order to add struct Table to internal table hash.
> > sqlite3EndTable() contains call of sql_table_def_rebuild() which in
> > turn copies space_def to malloc. However, it makes no sence to call
> > rebuild during the first stage, since this sample of struct Table will
> > be destroyed at the end of initial parsing and will be resurrected at
> > the second stage from the scratch.
I've checked the patch into 2.0 branch.

--
Regards, Kirill Yukhin