[tarantool-patches] Re: [PATCH v3 4/4] netbox: introduce iterable future objects

Konstantin Osipov kostja at tarantool.org
Thu Jun 7 15:56:38 MSK 2018


* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/06/02 02:09]:
> Netbox has two major ways to execute a request: sync and async.
> During execution of any a server can send multiplie responses via
> IPROTO_CHUNK. And the execution ways differ in how to handle the
> chunks (called messages or pushes).

Please don't use asserts. They are hell to debug. Please use
tap suite if you need to check things, or simple output the result
you expect.

The patch itself looks good to me. Did you send a message to
docbot about the new API?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list