[tarantool-patches] Re: [PATCH] sql: remove redundant goto from VDBE prologue

n.pettik korablev at tarantool.org
Mon Jun 18 23:55:48 MSK 2018


>> Thx for refactoring, but it wouldn’t work this way:
>> We must firstly make lable to jump (sqlite3VdbeJumpHere(v, 0);),
>> then test on emitting OP_TTransaction and const exprs (or both). If we need to
>> add such opcodes, then we should jump back. Otherwise, dismiss initial jump.
> 
> We do not need to change P2 until it is really needed. That is what I
> mean.

Ok, my apologies for misunderstanding. I pushed your changes.



More information about the Tarantool-patches mailing list