[tarantool-patches] Re: [PATCH] sql: remove redundant goto from VDBE prologue

[Vladislav Shpilevoy]

Thanks. Now LGTM.

On 18/06/2018 23:55, n.pettik wrote:
> 
>>> Thx for refactoring, but it wouldn’t work this way:
>>> We must firstly make lable to jump (sqlite3VdbeJumpHere(v, 0);),
>>> then test on emitting OP_TTransaction and const exprs (or both). If we need to
>>> add such opcodes, then we should jump back. Otherwise, dismiss initial jump.
>>
>> We do not need to change P2 until it is really needed. That is what I
>> mean.
> 
> Ok, my apologies for misunderstanding. I pushed your changes.
>