[tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless legacy Cursor hints

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Jun 13 11:48:00 MSK 2018


Hello. Thanks for the fixes!

LGTM.

On 13/06/2018 09:43, Kirill Shcherbatov wrote:
>> 1. The same comment. What have you write after '---'?
> Ok, I'll try to do not forget about it in next time. It were not obvious for me to edit ./create_commits.sh result files.

./create_commits.sh is not a standard util. It is just my helper for multi-commit
patches. If you know how, you can implement Branch/Issue adding for single-commit
patches, and I will share it.

> 
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3121-useless-hints
> Issue: https://github.com/tarantool/tarantool/issues/3121
> 
>> 2. I have pushed my fixes as a separate commit. Please,
>> look, perceive and squash.
> Done. Tnx.
> 




More information about the Tarantool-patches mailing list