[tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless legacy Cursor hints

Kirill Shcherbatov kshcherbatov at tarantool.org
Tue Jun 19 12:41:42 MSK 2018


Nikita, please take a look.

On 13.06.2018 11:48, Vladislav Shpilevoy wrote:
> Hello. Thanks for the fixes!
> 
> LGTM.
> 
> On 13/06/2018 09:43, Kirill Shcherbatov wrote:
>>> 1. The same comment. What have you write after '---'?
>> Ok, I'll try to do not forget about it in next time. It were not obvious for me to edit ./create_commits.sh result files.
> 
> ./create_commits.sh is not a standard util. It is just my helper for multi-commit
> patches. If you know how, you can implement Branch/Issue adding for single-commit
> patches, and I will share it.
> 
>>
>> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3121-useless-hints
>> Issue: https://github.com/tarantool/tarantool/issues/3121
>>
>>> 2. I have pushed my fixes as a separate commit. Please,
>>> look, perceive and squash.
>> Done. Tnx.
>>
> 




More information about the Tarantool-patches mailing list