[tarantool-patches] Re: [PATCH 1/2] fiber: remove fiber local storage
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Thu Jun 14 20:33:42 MSK 2018
Hello. Thanks for the review!
On 14/06/2018 00:11, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/06/09 22:33]:
>> Replace it with more specific structures and pointers in order to
>> prepare to add `net` storage.
>>
>> This allows to make the code working with fiber storage simpler,
>> remove useless wrappers and casts, and in the next patch - remove
>> broken session.sync and add fiber sync.
>
> Please write a comment stating that under no circumstances fiber.h
> is allowed to include application-specific headers, one only is allowed to add opaque
> pointers to the storage struct. I actually thought that you're
> going to make it more general, adopting a concept similar to Lua
> stack. Anyway, the simpler the better, we can make it more general
> when we need it, it's OK to push.
I have added the comment to the code:
@@ -331,6 +331,11 @@ struct fiber_attr {
void
fiber_attr_create(struct fiber_attr *fiber_attr);
+/**
+ * Under no circumstances this header file is allowed to include
+ * application-specific headers like session.h or txn.h. One only
+ * is allowed to announce a struct and add opaque pointer to it.
+ */
struct session;
struct txn;
struct credentials;
And to the commit message.
The patchset is pushed.
>> ---
>> src/box/session.cc | 4 +--
>> src/box/session.h | 14 ++++------
>> src/box/txn.c | 2 +-
>> src/box/txn.h | 2 +-
>> src/fiber.c | 9 ++----
>> src/fiber.h | 80 +++++++++++++++++++----------------------------------
>> src/fiber_channel.c | 31 ++++++---------------
>> src/lua/fiber.c | 19 ++++++-------
>
More information about the Tarantool-patches
mailing list