[tarantool-patches] Re: [PATCH 1/2] fiber: remove fiber local storage

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/06/09 22:33]:
> Replace it with more specific structures and pointers in order to
> prepare to add `net` storage.
> 
> This allows to make the code working with fiber storage simpler,
> remove useless wrappers and casts, and in the next patch - remove
> broken session.sync and add fiber sync.

Please write a comment stating that under no circumstances fiber.h
is allowed to include application-specific headers, one only is allowed to add opaque
pointers to the storage struct. I actually thought that you're
going to make it more general, adopting a concept similar to Lua
stack. Anyway, the simpler the better, we can make it more general
when we need it, it's OK to push.
> ---
>  src/box/session.cc  |  4 +--
>  src/box/session.h   | 14 ++++------
>  src/box/txn.c       |  2 +-
>  src/box/txn.h       |  2 +-
>  src/fiber.c         |  9 ++----
>  src/fiber.h         | 80 +++++++++++++++++++----------------------------------
>  src/fiber_channel.c | 31 ++++++---------------
>  src/lua/fiber.c     | 19 ++++++-------

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov