[tarantool-patches] Re: [PATCH 0/2] Box.session.sync

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sat Jun 9 20:58:28 MSK 2018


Sorry. Forgot the description.

The patchset fixes box.session.sync(). Before the patchset
box.session.sync() is session global, and is changed after
a new request arrives. So box.session.sync() can be safely
used only when a connection behind the session is not
multiplexed.

But box.session.push() can be used in a multiplexed
connection and uses box.session.sync() as a default
sync. So it needs box.session.sync() be request local.

On 09/06/2018 20:49, Vladislav Shpilevoy wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3450-session-sync
> Issue: https://github.com/tarantool/tarantool/issues/3450
> 
> Vladislav Shpilevoy (2):
>    fiber: remove fiber local storage
>    session: fix box.session.sync()
> 
>   src/box/iproto.cc             | 11 ++++--
>   src/box/session.cc            |  4 +-
>   src/box/session.h             | 31 ++++++---------
>   src/box/txn.c                 |  2 +-
>   src/box/txn.h                 |  2 +-
>   src/fiber.c                   |  9 +----
>   src/fiber.h                   | 89 ++++++++++++++++++-------------------------
>   src/fiber_channel.c           | 31 +++++----------
>   src/lua/fiber.c               | 19 ++++-----
>   test/box-tap/session.test.lua | 29 +++++++++++++-
>   10 files changed, 106 insertions(+), 121 deletions(-)
> 




More information about the Tarantool-patches mailing list