[tarantool-patches] Re: [tarantool-patches] [PATCH v1 1/1] sql: drop useless legacy Cursor hints
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Sun Jun 10 00:41:30 MSK 2018
Hello. Thanks for the patch!
>
>Deleted BTREE_BULKLOAD and OPFLAG_BULKCSR as there become
>useless since btree.c was dropped as a part of #2419.
>Removed SQLITE_ENABLE_CURSOR_HINTS sections as this code
>has never been in use.
>Start use OPFLAG_SEEKEQ instead of equal BTREE_SEEK_EQ as
>this macro name has no sense since no btree present in SQL.
>
>Resolves #3121.
>---
1. The same comment. What have you write after '---'?
2. I have pushed my fixes as a separate commit. Please,
look, perceive and squash.
> src/box/sql.c | 4 +-
> src/box/sql/build.c | 4 +-
> src/box/sql/cursor.c | 2 +-
> src/box/sql/cursor.h | 16 ----
> src/box/sql/expr.c | 18 ----
> src/box/sql/insert.c | 1 -
> src/box/sql/sqliteInt.h | 6 --
> src/box/sql/vdbe.c | 19 ++--
> src/box/sql/vdbe.h | 3 -
> src/box/sql/vdbeaux.c | 133 ---------------------------
> src/box/sql/where.c | 6 --
> src/box/sql/wherecode.c | 234 ------------------------------------------------
> 12 files changed, 11 insertions(+), 435 deletions(-)
>
More information about the Tarantool-patches
mailing list