[tarantool-patches] Re: [PATCH v1 1/1] sql: disallow division by zero
Kirill Shcherbatov
kshcherbatov at tarantool.org
Fri Jul 13 14:49:28 MSK 2018
Hi! Thank you for review.
> 1. Typo.
Fixed.
> 2. Garbage comment.Dropped. It wasn't mine.
> 3. Such huge test for division by zero is overkill. Please, fix the test to
> avoid division by zero. Obviously it was not about divisions.
Ok, I've changed one sign to fix this test case:
return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct (abs((abs(c)/abs(c)))/abs((abs(11)/abs(+case .....
return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct (abs((abs(c)/abs(c)))/abs((abs(11)*abs(+case .....
Test result didn't change.
More information about the Tarantool-patches
mailing list