Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton
arkholga at tarantool.org
Tue Jul 17 17:25:40 MSK 2018
>Вторник, 17 июля 2018, 17:22 +03:00 от Vladimir Davydov <vdavydov.dev at gmail.com>:
>On Tue, Jul 17, 2018 at 05:05:28PM +0300, Olga Arkhangelskaia wrote:
>> >Вторник, 17 июля 2018, 16:13 +03:00 от Vladimir Davydov < vdavydov.dev at gmail.com >:
>> >As this is the second version of this patch, you should add v2 to the
>> >subject line and write a brief change log.
>> Sorry, I remembered it after sending.
>> >On Tue, Jul 17, 2018 at 01:25:07PM +0300, Olga Arkhangelskaia wrote:
>> >> Added test to check if the valid syslog configuration is ok.
>> >> Issue: #3502
>> >Should be:
>> >Closes #3502
>> Is ir because it is a bug? Because Kirill told me about Issue: and Branch: and then links.
>Forget about everything Kirill told you ;-) Just use patches submitted
>by other team members as sample (you should be subscribed to the mailing
>list so you can see all of them).
>We mention an issue in the commit message so that it is recognized by
>GitHub. E.g. 'Closes ####' will make GitHub close the issue once the
>commit is pushed to the trunk.
>We also include hyperlinks to the issue and branch in the patch email.
>These are for the reviewer. They are not committed to the git.
>BTW I see that you use Mail.Ru web interface. Please don't - it mangles
>code snippets. I strongly recommend you to install a mail user agent,
I know, every day I promise myself to do it. =)))
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Tarantool-patches