<HTML><BODY><br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Вторник, 17 июля 2018, 17:22 +03:00 от Vladimir Davydov <vdavydov.dev@gmail.com>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15318373580000000966_BODY">On Tue, Jul 17, 2018 at 05:05:28PM +0300, Olga Arkhangelskaia wrote:<br>
> <br>
> <br>
> <br>
> >Вторник, 17 июля 2018, 16:13 +03:00 от Vladimir Davydov <<a href="mailto:vdavydov.dev@gmail.com">vdavydov.dev@gmail.com</a>>:<br>
> ><br>
> >As this is the second version of this patch, you should add v2 to the<br>
> >subject line and write a brief change log. <br>
> Sorry, I remembered it after sending.<br>
> ><br>
> ><br>
> >On Tue, Jul 17, 2018 at 01:25:07PM +0300, Olga Arkhangelskaia wrote:<br>
> >> Added test to check if the valid syslog configuration is ok.<br>
> >> <br>
> >> Issue: #3502<br>
> ><br>
> >Should be:<br>
> ><br>
> >Closes #3502 <br>
> Is ir because it is a bug? Because Kirill told me about Issue: and Branch: and then links.<br><br>
Forget about everything Kirill told you ;-) Just use patches submitted<br>
by other team members as sample (you should be subscribed to the mailing<br>
list so you can see all of them).<br><br>
We mention an issue in the commit message so that it is recognized by<br>
GitHub. E.g. 'Closes ####' will make GitHub close the issue once the<br>
commit is pushed to the trunk.<br><br>
We also include hyperlinks to the issue and branch in the patch email.<br>
These are for the reviewer. They are not committed to the git.<br><br></div></div></div></div></blockquote><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15318373580000000966_BODY"><br>
BTW I see that you use Mail.Ru web interface. Please don't - it mangles<br>
code snippets. I strongly recommend you to install a mail user agent,<br>
e.g. Thuderbird.<br></div></div></div></div></blockquote>
I know, every day I promise myself to do it. =)))<br>
<br>-- <br>Olga Arkhangelskaia<br></BODY></HTML>