Re[2]: [PATCH] Fix force_recovery on empty xlog

[Konstantin Belyavskiy]

branch:  https://github.com/tarantool/tarantool/tree/gh-3026-fix-force-recovery-on-empty-xlog  

Fixed most of issues except the one about rename vs. delete. Need farther discussion
Also separate suggestion about using 'force_recovery' to different patch.


>Четверг, 25 января 2018, 22:27 +03:00 от Konstantin Osipov <kostja at tarantool.org>:
>
>* Vladimir Davydov < vdavydov.dev at gmail.com > [18/01/25 19:18]:
>
>> > @@ -1799,7 +1798,8 @@ xlog_cursor_openfd(struct xlog_cursor *i, int fd, const char *name)
>> >  	if (rc == -1)
>> >  		goto error;
>> >  	if (rc > 0) {
>> > -		diag_set(XlogError, "Unexpected end of file");
>> > +		diag_set(XlogError, "Unexpected end of file %s, to fix "
>> > +			 "try to run with 'force_recovery = true'", name);
>> 
>> This is definitely a wrong place to recommend using force_recovery,
>> because there are other errors that can be remedied by this option.
>> This should either be a part of every XlogError (not sure about that)
>> or reside somewhere in recover_remaining_wals().
>
>I already mentioned to Konstantin and Roman that I believe we need
>to fix this problem by adding stacked diagnostics. Besides, it's a
>different bug, so should be in a different patch anyway.
>
>-- 
>Konstantin Osipov, Moscow, Russia,  +7 903 626 22 32
>http://tarantool.org -  www.twitter.com/kostja_osipov


С уважением,
Konstantin Belyavskiy
k.belyavskiy at tarantool.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180129/60f5495c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-force_recovery-on-empty-xlog.patch
Type: application/x-patch
Size: 6545 bytes
Desc: not available
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180129/60f5495c/attachment.bin>