<HTML><BODY>branch: <a href="https://github.com/tarantool/tarantool/tree/gh-3026-fix-force-recovery-on-empty-xlog">https://github.com/tarantool/tarantool/tree/gh-3026-fix-force-recovery-on-empty-xlog</a> <br><br>Fixed most of issues except the one about rename vs. delete. Need farther discussion<br>Also separate suggestion about using 'force_recovery' to different patch.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Четверг, 25 января 2018, 22:27 +03:00 от Konstantin Osipov <kostja@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15169084540000000507_BODY">* Vladimir Davydov <<a href="mailto:vdavydov.dev@gmail.com">vdavydov.dev@gmail.com</a>> [18/01/25 19:18]:<br>
<br>
<div class="mail-quote-collapse">> > @@ -1799,7 +1798,8 @@ xlog_cursor_openfd(struct xlog_cursor *i, int fd, const char *name)<br>
> > if (rc == -1)<br>
> > goto error;<br>
> > if (rc > 0) {<br>
> > - diag_set(XlogError, "Unexpected end of file");<br>
> > + diag_set(XlogError, "Unexpected end of file %s, to fix "<br>
> > + "try to run with 'force_recovery = true'", name);<br>
> <br>
> This is definitely a wrong place to recommend using force_recovery,<br>
> because there are other errors that can be remedied by this option.<br>
> This should either be a part of every XlogError (not sure about that)<br>
> or reside somewhere in recover_remaining_wals().<br>
</div><br>
I already mentioned to Konstantin and Roman that I believe we need<br>
to fix this problem by adding stacked diagnostics. Besides, it's a<br>
different bug, so should be in a different patch anyway.<br>
<br>
-- <br>
Konstantin Osipov, Moscow, Russia, <span class="js-phone-number">+7 903 626 22 32</span><br>
<a href="http://tarantool.org" target="_blank">http://tarantool.org</a> - <a href="http://www.twitter.com/kostja_osipov" target="_blank">www.twitter.com/kostja_osipov</a><br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br>С уважением,<br>Konstantin Belyavskiy<br>k.belyavskiy@tarantool.org<br></BODY></HTML>