[patches] [cfg 1/1] cfg: Add constraints on box.cfg params

[Vladimir Davydov]

On Thu, Feb 22, 2018 at 11:04:17AM +0300, imarkov wrote:
> From: IlyaMarkovMipt <markovilya197 at gmail.com>
> 
> * Introduce limitations on combinations of box.cfg parameters
> * Add restriction on log type file and log_nonblock=true
> * Add restriction on log type syslog and log_format json
> * Each restriction creates error in case of its violation

So box.cfg{log = 'tarantool.log'} isn't going to work anymore, because
log_nonblock is set to true by default, is it? I assume that's why you
patched all those tests. If so, I'm afraid that will break a lot of
existing deployments...

> 
> Relates #3014 #3072
> ---
>  src/box/lua/load_cfg.lua                 | 54 ++++++++++++++++++++++++++++++++
>  test/app-tap/init_script.result          |  2 +-
>  test/app-tap/init_script.test.lua        |  3 +-
>  test/app-tap/logger.test.lua             |  5 +--
>  test/app/app.lua                         |  3 +-
>  test/box-py/box.lua                      |  3 +-
>  test/box-tap/auth.test.lua               |  1 +
>  test/box-tap/cfg.test.lua                | 21 +++++++++----
>  test/box-tap/cfgup.test.lua              |  3 +-
>  test/box-tap/session.test.lua            |  1 +
>  test/box-tap/trigger_atexit.test.lua     |  1 +
>  test/box-tap/trigger_yield.test.lua      |  3 +-
>  test/box/admin.result                    |  2 +-
>  test/box/backup_test.lua                 |  2 +-
>  test/box/box.lua                         |  1 +
>  test/box/cfg.result                      |  4 +--
>  test/box/lua/cfg_bad_vinyl_dir.lua       |  3 +-
>  test/box/lua/cfg_test1.lua               |  1 +
>  test/box/lua/cfg_test2.lua               |  3 +-
>  test/box/lua/cfg_test3.lua               |  1 +
>  test/box/lua/cfg_test4.lua               |  1 +
>  test/box/proxy.lua                       |  3 +-
>  test/box/tiny.lua                        |  3 +-
>  test/engine/box.lua                      |  1 +
>  test/engine_long/box.lua                 |  1 +
>  test/long_run-py/box.lua                 |  1 +
>  test/replication-py/failed.lua           |  1 +
>  test/replication-py/master.lua           |  1 +
>  test/replication-py/replica.lua          |  1 +
>  test/replication/autobootstrap.lua       |  1 +
>  test/replication/autobootstrap_guest.lua |  1 +
>  test/replication/hot_standby.lua         |  1 +
>  test/replication/master.lua              |  1 +
>  test/replication/on_replace.lua          |  1 +
>  test/replication/quorum.lua              |  1 +
>  test/replication/replica.lua             |  1 +
>  test/replication/replica_ack.lua         |  1 +
>  test/replication/replica_timeout.lua     |  1 +
>  test/replication/replica_uuid.lua        |  1 +
>  test/replication/wal_off.lua             |  1 +
>  test/vinyl/bad_run_indexes.lua           |  1 +
>  test/vinyl/force_recovery.lua            |  1 +
>  test/vinyl/info.lua                      |  1 +
>  test/vinyl/join_quota.lua                |  1 +
>  test/vinyl/low_quota.lua                 |  1 +
>  test/vinyl/upgrade.lua                   |  1 +
>  test/vinyl/vinyl.lua                     |  1 +
>  test/wal_off/wal.lua                     |  3 +-
>  test/xlog-py/box.lua                     |  3 +-
>  test/xlog/force_recovery.lua             |  3 +-
>  test/xlog/panic.lua                      |  3 +-
>  test/xlog/replica.lua                    |  1 +
>  test/xlog/upgrade.lua                    |  3 +-
>  test/xlog/xlog.lua                       |  3 +-
>  54 files changed, 137 insertions(+), 30 deletions(-)