[tarantool-patches] Re: [PATCH 4/6] sql: don't add string of 'CREATE TABLE...' to space opts

[Vladislav Shpilevoy]

Thanks for the patch! See 1 comment and review fixes below.

On 10/12/2018 00:30, Nikita Pettik wrote:
> We don't rely no more on this string anymore and it can be removed for

'no more on this anymore' - please, rephrase. Sounds a little
tautological.

> ordinary tables. However, it is still used to hold SELECT body for view.
> 
> Part of #2647
> ---
>   src/box/sql.c           |   8 +-
>   src/box/sql/analyze.c   |   2 +-
>   src/box/sql/build.c     | 242 ++----------------------------------------------
>   src/box/sql/pragma.c    |   2 -
>   src/box/sql/sqliteInt.h |   1 -
>   test/sql/upgrade.result |   8 +-
>   test/sql/view.result    |   3 +
>   test/sql/view.test.lua  |   1 +
>   8 files changed, 19 insertions(+), 248 deletions(-)
> 

My review fix here and on the branch:

====================================================================

commit e4ea3a20c71e73426a9ea2478b55c346b0ca3a41
Author: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
Date:   Mon Dec 10 16:57:18 2018 +0300

     Review fix

diff --git a/src/box/sql/pragma.c b/src/box/sql/pragma.c
index 325c272b0..ce1f4aed7 100644
--- a/src/box/sql/pragma.c
+++ b/src/box/sql/pragma.c
@@ -294,7 +294,7 @@ sql_pragma_table_info(struct Parse *parse, const char *tbl_name)
  static int
  sql_pragma_table_stats(struct space *space, void *data)
  {
-	if (space->def->opts.sql == NULL || space->def->opts.is_view)
+	if (space->def->opts.is_view)
  		return 0;
  	struct Parse *parse = (struct Parse *) data;
  	struct index *pk = space_index(space, 0);