[tarantool-patches] Re: [PATCH 4/6] sql: don't add string of 'CREATE TABLE...' to space opts

[n.pettik]

> On 10 Dec 2018, at 17:17, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
> 
> Thanks for the patch! See 1 comment and review fixes below.
> 
> On 10/12/2018 00:30, Nikita Pettik wrote:
>> We don't rely no more on this string anymore and it can be removed for
> 
> 'no more on this anymore' - please, rephrase. Sounds a little
> tautological.

Rephrased:
    
    We don't rely on this string anymore and it can be removed for ordinary
    tables. However, it is still used to hold SELECT body for view.

> 
>> ordinary tables. However, it is still used to hold SELECT body for view.
>> Part of #2647
>> ---
>>  src/box/sql.c           |   8 +-
>>  src/box/sql/analyze.c   |   2 +-
>>  src/box/sql/build.c     | 242 ++----------------------------------------------
>>  src/box/sql/pragma.c    |   2 -
>>  src/box/sql/sqliteInt.h |   1 -
>>  test/sql/upgrade.result |   8 +-
>>  test/sql/view.result    |   3 +
>>  test/sql/view.test.lua  |   1 +
>>  8 files changed, 19 insertions(+), 248 deletions(-)
> 
> My review fix here and on the branch:

Applied.