[tarantool-patches] Re: [PATCH 1/5] sql: prohibit creation of FK on unexisting tables

n.pettik korablev at tarantool.org
Wed Aug 1 23:54:33 MSK 2018


> 1. sql-tap/fkey2.test.lua fails on this commit. Travis fails
> as well.

Does it really matter?:) Could you forgive me these fails and
make me avoid suffering? Anyway, they are completely fixed
in second patch, but in scope of current patch they can be only
partially repaired. Hence, it would look like I fix in the second patch
fixes made in first one..

> 2. I have pushed more review fixes in a separate commit (the
> test fails before it too). Please, squash if you are ok.

Ok, I’ve squashed them.





More information about the Tarantool-patches mailing list