[tarantool-patches] Re: [PATCH 1/5] sql: prohibit creation of FK on unexisting tables

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Aug 3 01:15:10 MSK 2018


Hi! Thanks for the fixes! See 1 comment below and a
separate commit on the branch.

On 01/08/2018 23:54, n.pettik wrote:
> 
>> 1. sql-tap/fkey2.test.lua fails on this commit. Travis fails
>> as well.
> 
> Does it really matter?:) Could you forgive me these fails and
> make me avoid suffering? Anyway, they are completely fixed
> in second patch, but in scope of current patch they can be only
> partially repaired. Hence, it would look like I fix in the second patch
> fixes made in first one..

It had been failing even on the last commit. So it really mattered.

On the second commit it fails now as well.

Please, make it working. It is not okay, that a non-trivial patch
breaks tests, that somehow stop failing after some non-linked
changes.




More information about the Tarantool-patches mailing list