[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool

[Alex Khatskevich]

Accepted.


On 17.08.2018 11:37, n.pettik at corp.mail.ru wrote:
>
>> On 17 Aug 2018, at 11:25, Alex Khatskevich 
>> <avkhatskevich at tarantool.org <mailto:avkhatskevich at tarantool.org>> wrote:
>>
>>> GLOB is a legacy extension for LIKE from SQLite. As we want our SQL to
>>> be close to ANSI SQL & LIKE to depend on collations, we do not want to
>>> support it. This patch totally removes it from Tarantool along with any
>>> mentions of it.
>> 1.We delete it because it is not working properly, and instead of 
>> fixing it we
>> want to replace it with more general regexp. Delete other unnecessary 
>> thoughts
>> from this message.
>> 2. Do not use "we", "our" in commit messages.
>
> Why? Ofс it would sound more like documentation, but AFAIK we don’t
> force this restriction. You can check out commit messages from other
> contributors who use ‘we’ and ‘I':
>
> https://github.com/tarantool/tarantool/commit/f4625e64eb99c17910d3f0bcd323e5d82b6d5b31
> https://github.com/tarantool/tarantool/commit/46f50aadedfa87a16e2618da55924b185376b58a
> https://github.com/tarantool/tarantool/commit/1331d232476f17b9ec5be45175233d1b5454d1fd
>
> etc
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180817/63e1c1a1/attachment.html>