<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Accepted.<br>
</p>
<br>
<div class="moz-cite-prefix">On 17.08.2018 11:37,
<a class="moz-txt-link-abbreviated" href="mailto:n.pettik@corp.mail.ru">n.pettik@corp.mail.ru</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:04D02794-07A5-4146-9144-84EE720C8656@corp.mail.ru">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;" class=""><br
class="">
<div>
<blockquote type="cite" class="">
<div class="">On 17 Aug 2018, at 11:25, Alex Khatskevich
<<a href="mailto:avkhatskevich@tarantool.org" class=""
moz-do-not-send="true">avkhatskevich@tarantool.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">
<blockquote type="cite" style="font-family: Helvetica;
font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px;" class="">GLOB is a
legacy extension for LIKE from SQLite. As we want our
SQL to<br class="">
be close to ANSI SQL & LIKE to depend on
collations, we do not want to<br class="">
support it. This patch totally removes it from
Tarantool along with any<br class="">
mentions of it.<br class="">
</blockquote>
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px; float: none; display:
inline !important;" class="">1.We delete it because it
is not working properly, and instead of fixing it we</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px; float: none; display:
inline !important;" class="">want to replace it with
more general regexp. Delete other unnecessary thoughts</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px; float: none; display:
inline !important;" class="">from this message.</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px; float: none; display:
inline !important;" class="">2. Do not use "we", "our"
in commit messages.</span></div>
</div>
</blockquote>
<br class="">
</div>
<div>Why? Ofс it would sound more like documentation, but AFAIK
we don’t</div>
<div>force this restriction. You can check out commit messages
from other</div>
<div>contributors who use ‘we’ and ‘I':</div>
<div><br class="">
</div>
<div><a
href="https://github.com/tarantool/tarantool/commit/f4625e64eb99c17910d3f0bcd323e5d82b6d5b31"
class="" moz-do-not-send="true">https://github.com/tarantool/tarantool/commit/f4625e64eb99c17910d3f0bcd323e5d82b6d5b31</a></div>
<div><a
href="https://github.com/tarantool/tarantool/commit/46f50aadedfa87a16e2618da55924b185376b58a"
class="" moz-do-not-send="true">https://github.com/tarantool/tarantool/commit/46f50aadedfa87a16e2618da55924b185376b58a</a></div>
<div><a
href="https://github.com/tarantool/tarantool/commit/1331d232476f17b9ec5be45175233d1b5454d1fd"
class="" moz-do-not-send="true">https://github.com/tarantool/tarantool/commit/1331d232476f17b9ec5be45175233d1b5454d1fd</a></div>
<div><br class="">
</div>
<div>etc</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>