[tarantool-patches] Re: [PATCH 3/3] iproto: allow to configure IPROTO_MSG_MAX

Vladimir Davydov vdavydov.dev at gmail.com
Tue Apr 24 11:04:13 MSK 2018


On Mon, Apr 23, 2018 at 08:00:13PM +0300, Vladislav Shpilevoy wrote:
> > > +		if (cfg_msg.need_update_uri) {
> > > +			if (evio_service_is_active(&binary))
> > > +				evio_service_stop(&binary);
> > > +			if (cfg_msg.uri != NULL)
> > > +				evio_service_bind(&binary, cfg_msg.uri);
> > > +		}
> > > +		if (cfg_msg.need_update_msg_max) {
> > > +			cpipe_set_max_input(&tx_pipe,
> > > +					    cfg_msg.iproto_msg_max / 2);
> > > +			int old = iproto_msg_max;
> > > +			iproto_msg_max = cfg_msg.iproto_msg_max;
> > > +			if (old < iproto_msg_max)
> > > +				iproto_resume();
> > > +		}
> > 
> > This is a matter of personal taste, but I'd prefer to not introduce
> > these extra flags, i.e.
> 
> It is not possible for URI, because URI == NULL is possible update. So
> for URI the flag is necessary. For msg_max I added this for unifying. If you
> want, I can remove need_update_msg_max. Must I do it?

No need then. Leave it as is for consistency.



More information about the Tarantool-patches mailing list