[tarantool-patches] Re: [PATCH 1/3] iproto: rename iproto_bind_msg to iproto_cfg_msg
v.shpilevoy at tarantool.org
Mon Apr 23 20:00:16 MSK 2018
Hello. Thanks for review!
On 23/04/2018 14:22, Vladimir Davydov wrote:
> On Sat, Apr 21, 2018 at 01:52:09AM +0300, Vladislav Shpilevoy wrote:
>> IProto_bind_msg is used by TX thread to udpate bind address in
>> IProto thread with no explicit locking anything.
>> In #3320 new IProto dynamic configuration parameter appears -
>> 'iproto_msg_max' which regulates how many IProto requests can be
>> in fly.
>> The idea is to reuse iproto_bind_msg for this.
>> Part of #3320
>> src/box/iproto.cc | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
> I don't see any point in this patch. Patch 3 overwrites half of it
> anyway so it doesn't really facilitate review. Please squash it.
More information about the Tarantool-patches