From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8087168E165; Thu, 9 Nov 2023 03:03:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8087168E165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699488221; bh=cGRK65O1lE648H7sL9O8OgAfQiveRtFtHkKDIp6Si7M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YzF95UfOa9k+LuJHIO21tw8F0NX0D5g0vqSTnUhNzkZDHbSS7SMCko9CwGUBLvMaS tQZQnCMvNnwC4Q+JWVp8/8E8dmkwUwh+05vSwmJ4rtT3LHl/A9SuJ/lT4wQ4BNMAsz o43m2MAsoArQ9tLvKYlLYh0PPb6iOBCQByf7yT8k= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A558F68E165 for ; Thu, 9 Nov 2023 03:03:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A558F68E165 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1r0sWJ-005PKZ-0Y; Thu, 09 Nov 2023 03:03:39 +0300 Date: Thu, 9 Nov 2023 03:03:38 +0300 To: Sergey Kaplun Message-ID: References: <20231107210616.53138-1-max.kokryashkin@gmail.com> <20231107210616.53138-2-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C2A6B03AB739174C16ACAE482185BA9D0B41A7F511DCAA9600894C459B0CD1B919EAA76A3ED63A791FA848D7F7D981658F92C501743DC17CF9D66BFDEA673F01 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A1DB0B089319D380EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063742E71BDDD354FC988638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BC5E4EAB6A586B80EC5A1416821CAC34117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCEA77C8EAE1CE44B0A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0F098B145E00970258D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE31E1736EDDE8D4790C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C062BEEFFB5F8EA3E2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5373BDD99B366DCC43968C79A4A79B6560E89AB873ECBA7F8F87CCE6106E1FC07E67D4AC08A07B9B01F9513A7CA91E555CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF3426D80FE971E93D85659F6897C0C8BEE9BC5D95059DE9CC153B04417E860C417649A938D59E33ED2B33B16BC67043E01C890A9786CFC672186A3A8AB99CFE83A74DFFEFA5DC0E7F02C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGx6zOZpnTND1CJcXOlRFag== X-Mailru-Sender: 7940E2A4EB16C9974D1995FACA6D044E19EAA76A3ED63A791FA848D7F7D98165E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Fixed, your comments, branch is force-pushed, here is the diff: === diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua index 71efc260..450ca8d4 100644 --- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua +++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua @@ -21,8 +21,8 @@ local function test_f() -- Make GC aggressive enough to end the atomic phase before -- exiting the trace. collectgarbage('setstepmul', 400) - -- The number of iterations is empirical, just big enough for the - -- issue to strike. + -- The number of iterations is empirical, just big enough for + -- the issue to strike. for _ = 1, 4000 do new_bad_cdata() end diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua index dfef11e5..f0d11f6f 100644 --- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua +++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua @@ -7,5 +7,5 @@ test:plan(1) local script = require('utils').exec.makecmd(arg, { redirect = '2>&1' }) local output = script() -test:like(output, '.*ERROR in finalizer:.*') +test:like(output, 'ERROR in finalizer:') test:done(true) diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua index fdd9ced1..3fe48c77 100644 --- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua +++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua @@ -9,8 +9,8 @@ local function test_f() -- Make GC aggressive enough to end the atomic phase before -- exiting the trace. collectgarbage('setstepmul', 400) - -- The number of iterations is empirical, just big enough for the - -- issue to strike. + -- The number of iterations is empirical, just big enough for + -- the issue to strike. for _ = 1, 4000 do new_bad_cdata() end ===