From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 35B829E43DC; Thu, 1 Feb 2024 12:05:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 35B829E43DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706778347; bh=vUHBshsdsN5EoRlZB1zT5ESybfRfc/EqO759cOqNSHA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=f0NARTye3hiZy1y+8YMoDHdH+yrOK7u6hKfqG6zjotQuVtyBwvEWp3mZTjCEpKFau wqdoUx3w88JBewtyGO1k/Bczou5rW+lFAlngsAn1PG7hQIvB9ZXZClpdl+/wYZ51mQ PTW9f+NZ+vKu7HiJuY0prlKLRGqu8ZBz7VnwPXro= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 451759E43D5 for ; Thu, 1 Feb 2024 12:05:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 451759E43D5 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1rVT0y-00000002WOk-07Yi; Thu, 01 Feb 2024 12:05:44 +0300 Date: Thu, 1 Feb 2024 12:05:43 +0300 To: Sergey Kaplun Message-ID: References: <2a5fbe653d26a7a9d3d8d627f7345cd78ceec93a.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a5fbe653d26a7a9d3d8d627f7345cd78ceec93a.1706520765.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9A3FCF9DB4FFE095582EF5822AA9EC17FDBB59FDA0500D88D182A05F5380850400F79ACCA0ADED0E3F378A8CA21F699D6EF7258770DAF2C2742E0A2E5ABDEE8B2E4D8D3D339598BC1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CA8E915ACC910FBDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379FED03E15F715FAA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D822AD6DE690DEA284CE7F940A866C75C8BB4E7098FBEBC8C0CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006370F9B9C81FEA0DEC7D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE78F84DE33370BE923EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5278DA827A17800CE7A03E8F3C2D3812562EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74ABCC139FF3F849B731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5595338AE85074F215002B1117B3ED696A16F4CFF1C82FAA9B2920F75BA9A967F823CB91A9FED034534781492E4B8EEAD1E02C13459908652BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF4D766D35654EAEC8EA7037E15AFE9A8FAC4867585B202F440D3F03AFA543107285EFCC6ECD454202BAF4CF3B87E910B105AD08F411A1363B5602AAA3686010A1693E0143466D955E5F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtymXELfbKAnb0w== X-Mailru-Sender: 7940E2A4EB16C9970E7603824FE97C2039F05F1585C1BCA6A81770BBF70E5A7DB2240C0F8AFCCC3AB6F7D78CE1F58EAD61AD1BC23DFB21333DDE9B364B0DF289BB83A8C3DAEBA78A61AAEF30F77CACB9EAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 20/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! Please consider my comments below. On Mon, Jan 29, 2024 at 01:45:20PM +0300, Sergey Kaplun wrote: > This patch changes `dofile()` (which uses an unreliable relative file > path and mutates `_G` with global functions to be defined) to the > corresponding `require()` of the helper functions. It adds groups with > the names of subtests and enables the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua | 141 ++++++++++--------- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 77 insertions(+), 65 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua > index 4bb5d903..cc123808 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua > @@ -1,77 +1,88 @@ > local ffi = require("ffi") > > -dofile("../common/ffi_util.inc") > +local checkfail = require("common.ffi.checkfail") > +local checktypes = require("common.ffi.checktypes") > > -checkfail({ > - "int", > - "int aa1; int aa2 ", > - "static int x;", > - "static const long long x = 1;", -- NYI > - "static const double x = 1;", -- NYI > - "static const bool x = 1;", -- NYI (intentional, need true/false) > - "struct { static int x = 1; };", > - ";;static int y" > -}, ffi.cdef) > +do --- checkfail More elaborate name would be nice. > + checkfail({ > + "int", > + "int aa1; int aa2 ", > + "static int x;", > + "static const long long x = 1;", -- NYI > + "static const double x = 1;", -- NYI > + "static const bool x = 1;", -- NYI (intentional, need true/false) > + "struct { static int x = 1; };", > + ";;static int y" > + }, ffi.cdef) > +end