From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 858AD589F42; Tue, 15 Aug 2023 16:10:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 858AD589F42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692105036; bh=EssuKKxcHqGjs1aZ+BaxOZuc2wpr+ydrDkHcdK/MunE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TOYTtyx0tTNQNTzdZEUbA+vsFFL0O/5tkt9efV5ceBeBuW0N3B5tMq2dMqMPqWFlG 1u52BKw4zmKKR8gOxkHVzvavmHOtuDoBAZcLYlYb3NoySwrtaZl2PaPhvDR8WerDPg k/ggqS5DFY7lHtyHXCaHYdCoFs3xPhf43i3iDITs= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 43F5A589F42 for ; Tue, 15 Aug 2023 16:10:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 43F5A589F42 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1qVtof-0005BJ-2k; Tue, 15 Aug 2023 16:10:34 +0300 Date: Tue, 15 Aug 2023 16:10:33 +0300 To: Sergey Kaplun Message-ID: References: <8bd95083805e240d65b2c02524ffb3ad8d91b414.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bd95083805e240d65b2c02524ffb3ad8d91b414.1691592488.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC804E38A5F9341E5D89B81E0241E25E490182A05F5380850405F8F00281AD839312DD0AD863E6A51F4BC590225C2351702B57618D1559BDE4C X-C1DE0DAB: 0D63561A33F958A5E06BB106CDA6B10106A1BE668B6BAC1C7ECCF1D4C929BCE6F87CCE6106E1FC07E67D4AC08A07B9B067F1C1C3ABB44F3ACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0AD5177F0B940C8B66ECE892A7B2722663E91682638B966EB3F662256BEEFA9527F5470C02331B94D33918D9094BB5179B371C31C82A81E14C02548E28EB602F4BCC7599197FAF09FB337FD76D11AF80A0D0E9EFF0EFEA87C455CACCBF8289005CAEA455F16B58544A21C197AAF4D2E4732965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hj75mPXi9sKbA== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407B7A159FFDE788250B429DDE04F621931B7F0BE324C9CF421D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit 10/19] Cleanup math function compilation and fix inconsistencies. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM On Wed, Aug 09, 2023 at 06:35:59PM +0300, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > (cherry picked from commit 5655be4546d9177890c69f0d0accac4773ff0887) > > This patch backports the aforementioned patch for mips and ppc, because > those architectures were stripped during the backporting via > 71ec8eb232d4dfa8df2cbbae65b799b2ce493979 ("Cleanup math function > compilation and fix inconsistencies."). This applies these missed diffs > to prevent conflict during backporting future patches. > > This patch just removes macros, that are no more in use. > > Sergey Kaplun: > * added the description for the problem > > Part of tarantool/tarantool#8825 > --- > src/lj_asm_mips.h | 1 - > src/lj_asm_ppc.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/lj_asm_mips.h b/src/lj_asm_mips.h > index a26a82cd..c27d8413 100644 > --- a/src/lj_asm_mips.h > +++ b/src/lj_asm_mips.h > @@ -1794,7 +1794,6 @@ static void asm_abs(ASMState *as, IRIns *ir) > } > #endif > > -#define asm_atan2(as, ir) asm_callid(as, ir, IRCALL_atan2) > #define asm_ldexp(as, ir) asm_callid(as, ir, IRCALL_ldexp) > > static void asm_arithov(ASMState *as, IRIns *ir) > diff --git a/src/lj_asm_ppc.h b/src/lj_asm_ppc.h > index 6cb608f7..6aaed058 100644 > --- a/src/lj_asm_ppc.h > +++ b/src/lj_asm_ppc.h > @@ -1390,7 +1390,6 @@ static void asm_neg(ASMState *as, IRIns *ir) > } > > #define asm_abs(as, ir) asm_fpunary(as, ir, PPCI_FABS) > -#define asm_atan2(as, ir) asm_callid(as, ir, IRCALL_atan2) > #define asm_ldexp(as, ir) asm_callid(as, ir, IRCALL_ldexp) > > static void asm_arithov(ASMState *as, IRIns *ir, PPCIns pi) > -- > 2.41.0 >