From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E70D759A35D; Sun, 13 Aug 2023 16:52:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E70D759A35D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691934729; bh=sKROmU38oNx/RYUeyUu5yDKfakL4nRannKOkwzK9vHM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LOu1CA44N2GdDPMNCRVf2zeXzd6OoJqDbfjZ2JpS3I3TjMZWaDVyGCYvu1LbXU8Ty HhFXE9bEkWlrJjE4swN7nn0P5r+sL97Dbu0oOPqYfXSw4Lz1zMa/8kbs0tqJiCtNwf Apfas+eEKKa7q9YV+O0Rz8dAuiAsoseZBLr47M/o= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [95.163.41.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B6AEF50D037 for ; Sun, 13 Aug 2023 16:52:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B6AEF50D037 Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1qVBVl-007Tv9-23; Sun, 13 Aug 2023 16:52:06 +0300 Date: Sun, 13 Aug 2023 16:52:04 +0300 To: Igor Munkin Message-ID: References: <2559a1d630bf893d22e6e37bef9d55710999832f.1691523040.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2559a1d630bf893d22e6e37bef9d55710999832f.1691523040.git.imun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC804E38A5F9341E5D89B81E0241E25E490182A05F538085040A9C49AA8CDA445AF5DB636F0AA0F970733FD46AAB494DD6F7530418B4F5F8A6E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637835928C62272F24E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C27E80B9001B9B72E288179982E4924B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC25677757F72FC461A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9CEDA8D6C8C3B0531D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE74E672349037D5FA5725E5C173C3A84C3C74813BC7F81EC8435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A559155536C501E8FD9820A8F55F21EEE1F14EACCBD8745D1AF87CCE6106E1FC07E67D4AC08A07B9B0735DFC8FA7AC1207CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D71B56C992F8AF19D45A4435B0DEA69BA35D1AAFEF518B7E66858F3E84FB34C87AA6EF8663A6DD9D1D7E09C32AA3244C9A5A149240194F447F29C287D8B7FEE06C2483212766842285A42E4C463514DC5DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojngxRbPBK1nGUoxvk7voOpg== X-Mailru-Sender: 0E9E14D9EC491FBA87EB92DCA6727BD28C0C627ED34D95EF5DB636F0AA0F9707F7F5837242FA16B204C9FB44FCBCE9EE92D99EB8CC7091A7ECEABDC5717908DEF544888E8238EB4872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except for a few typos below. On Tue, Aug 08, 2023 at 07:42:39PM +0000, Igor Munkin wrote: > Suppressed 4 occurrences of E131 ("continuation line unaligned for Typo: s/of/of the/ > hanging indent") error reported by pycodestyle[1]. The reasons, why > these violations are not fixed the way recommended in the docs are > below: > * The only difference between prefix and postfix loop statements (the > latter is used in various generators and comprehensions) is the > trailing colon. > * The surrounding code is quite complex consisting of the cascade of the > calls and list comprehensions. > > Hence, to emphasis the postfix loop used in list comprehensions, Typo: s/to emphasis/to emphasize/ > additional indent is preserved and inline suppressions are added. > > [1]: https://www.flake8rules.com/rules/E131.html > > Signed-off-by: Igor Munkin > --- > > **NB**: This patch will be placed between "[PATCH luajit 02/15] test: > fix E128 errors by pycodestyle" and "[PATCH luajit 03/15] test: fix E201 > and E202 errors by pycodestyle" on the branch. > > CI: https://github.com/tarantool/luajit/actions/runs/5800936024/job/15724104222 > > src/luajit-gdb.py | 4 ++-- > src/luajit_lldb.py | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index f9623e53..9dcddb17 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > @@ -553,7 +553,7 @@ def dump_stack(L, base=None, top=None): > ] > dump.extend([ > dump_stack_slot(L, maxstack + offset, base, top) > - for offset in range(red, 0, -1) > + for offset in range(red, 0, -1) # noqa: E131 > ]) > dump.extend([ > '{padding} Stack: {nstackslots: >5} slots {padding}'.format( > @@ -572,7 +572,7 @@ def dump_stack(L, base=None, top=None): > # Dump all data slots in the (framelink, top) interval. > dump.extend([ > dump_stack_slot(L, framelink + offset, base, top) > - for offset in range(frametop - framelink, 0, -1) > + for offset in range(frametop - framelink, 0, -1) # noqa: E131 > ]) > # Dump frame slot (2 slots in case of GC64). > dump.append(dump_framelink(L, framelink)) > diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py > index 53f3abca..13d9f2e3 100644 > --- a/src/luajit_lldb.py > +++ b/src/luajit_lldb.py > @@ -844,7 +844,7 @@ def dump_stack(L, base=None, top=None): > ] > dump.extend([ > dump_stack_slot(L, maxstack + offset, base, top) > - for offset in range(red, 0, -1) > + for offset in range(red, 0, -1) # noqa: E131 > ]) > dump.extend([ > '{padding} Stack: {nstackslots: >5} slots {padding}'.format( > @@ -864,7 +864,7 @@ def dump_stack(L, base=None, top=None): > # Dump all data slots in the (framelink, top) interval. > dump.extend([ > dump_stack_slot(L, framelink + offset, base, top) > - for offset in range(frametop - framelink, 0, -1) > + for offset in range(frametop - framelink, 0, -1) # noqa: E131 > ]) > # Dump frame slot (2 slots in case of GC64). > dump.append(dump_framelink(L, framelink)) > -- > 2.30.2 > Best regards, Maxim Kokryashkin