From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E9C449051F1; Tue, 19 Dec 2023 17:34:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9C449051F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1702996453; bh=3VrR4NPSFEZNsfQNjUKQU5UXJuRC2cFuM2HEVGf3A+0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EiBn9K/XrxLeZbn/E/+UOLCleSBdDPlNrISTUsieYJH6t8XzsjkHyS0LX/sTa51vN a2fv8cJXHeaP1738MTo/PgPYQd8MkEWH3b8o+GouBYZ4dKcKsFT0nFeaDT2VMpth88 En80sWHE9Ky0tD+Qqb5St0CDc9r5SwVzanIp267g= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5AD309051F6 for ; Tue, 19 Dec 2023 17:34:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5AD309051F6 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1rFbAg-00BBKR-1S; Tue, 19 Dec 2023 17:34:10 +0300 Date: Tue, 19 Dec 2023 17:34:10 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97533543916A0F71A84F3C54A5E5B8DE1EEF7405543D6F01ACD62213F67905E7AC3551B3B79A7CC55C6229DCA9F14C7485A4F5A68273832DB768ACFD3FE3A7A49 X-C1DE0DAB: 0D63561A33F958A52ADE0D3B277D1236483920239EA9BD1DDBA333413C0F5145F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFC5B4003BDCA8A279F157DD743FC16D2ED0636F16D0B532F7C50F6FFB56C1EF408926F27D50C27B5DE190DC598EAEA94FAC7415384DF7AB3DDA6082C68F8E8E74461A413F07889F2102C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgGTRFEPoGBQ+yZSU+Zoahw== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE4073ADCA6F523607CD65C60C1A97DFA5FB2B0D440EF7BA41D00D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! Fixed your comments, except for the comment about CMake policy. The policy you've mentioned is too new to include in our CMakeLists.txt. Branch is force pushed, diff is below: === diff --git a/test/LuaJIT-debug-extensions-tests/CMakeLists.txt b/test/LuaJIT-debug-extensions-tests/CMakeLists.txt index 3b38201d..1956cf2a 100644 --- a/test/LuaJIT-debug-extensions-tests/CMakeLists.txt +++ b/test/LuaJIT-debug-extensions-tests/CMakeLists.txt @@ -6,6 +6,15 @@ add_custom_target(LuaJIT-lldb-extension-tests DEPENDS ${LUAJIT_TEST_BINARY} ) +# Skip tests for Tarantool. +if(ENABLE_BUNDLED_LUAJIT) + message(WARNING + "Tarantool build, LuaJIT-lldb-extension-tests and " + "LuaJIT-gdb-extension-tests are dummy" + ) + return() +endif() + # Debug info is required for testing of extensions. if(NOT (CMAKE_BUILD_TYPE MATCHES Debug)) message(WARNING @@ -53,7 +56,7 @@ if(GDB) "DEBUGGER_COMMAND=${GDB}" ) add_custom_command(TARGET LuaJIT-gdb-extension-tests - COMMENT "Running luajit_dbg.py tests with gdb" + COMMENT "Running debug extension tests with gdb" COMMAND ${GDB_TEST_ENV} ${PYTHON_EXECUTABLE} ${TEST_SCRIPT_PATH} WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} @@ -68,7 +71,7 @@ if(LLDB) "DEBUGGER_COMMAND=${LLDB}" ) add_custom_command(TARGET LuaJIT-lldb-extension-tests - COMMENT "Running luajit_dbg.py tests with lldb" + COMMENT "Running debug extension tests with lldb" COMMAND ${LLDB_TEST_ENV} ${PYTHON_EXECUTABLE} ${TEST_SCRIPT_PATH} WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} diff --git a/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py b/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py index 6ef87473..380e4324 100644 --- a/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py +++ b/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py @@ -247,4 +247,5 @@ for test_cls in TestCaseBase.__subclasses__(): test_cls.test = lambda self: self.check() if __name__ == '__main__': + # XXX: Verbosity level 2 is the most verbose. unittest.main(verbosity=2) === Regards, Maxim Kokryashkin