From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B571C68E165; Thu, 9 Nov 2023 02:01:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B571C68E165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699484514; bh=j5Qdp0pRsVyZBirS7HCLyv4gJz6BqFCITTk2AKX3WEc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vpZFRwnNI5rUpsOKlMLWn6kATCntbtWGgKuPsWVv9wL/IKd3TVFKPGNbWP1EOrZZl WbnXVU8ULAOZec7/ZghCdXGC6Viv6plEqrH11/1wh5uDCeU680KL4vRSH1qVp7HUYC h3d5XS0zbwe56iPxYZb2gr1RgfJuqZ+tHc0dVNK8= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [95.163.41.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BE9BA648A01 for ; Thu, 9 Nov 2023 02:01:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BE9BA648A01 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1r0rYV-005alq-04; Thu, 09 Nov 2023 02:01:51 +0300 Date: Thu, 9 Nov 2023 02:01:50 +0300 To: Sergey Bronnikov Message-ID: References: <20230710122818.22221-1-m.kokryashkin@tarantool.org> <9aec4ca0-09c0-2692-81e6-5d391f06fd7b@tarantool.org> <1689345019.547057052@f380.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9562B317E0136C8D346679895B712F137819A527523E4D068182A05F5380850404C228DA9ACA6FE27FB61C5502CD3831C499D07ED256CAE6FDC53188AE619B9CFE3A205CB4960F685 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE92FB8C11ED3D88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B8B7BDBFF398D98FD973BF404DFEC889117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA91DCA69B2CC609F68D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD74539164518AE59735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5460130562B36A034D349F1177D3EA942CBDB9E86D3B0545BF87CCE6106E1FC07E67D4AC08A07B9B0735DFC8FA7AC1207CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF3470BEFA9F01F72CC54EB906AF8E2F53EBF6656325C6122A02D66C1D40F40BD0D917AD9EEFBA970E2B33B16BC67043E0EA84D15DCFA1AAC6B8E191DC8B890387A74DFFEFA5DC0E7F02C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGx6zOZpnTNARwPnSs1878A== X-Mailru-Sender: 7940E2A4EB16C9974D1995FACA6D044E899C84192559248E59619BEE173320A3E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! Fixed your comment, branch is force-pushed. Diff is below: === diff --git a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua index 347bd087..90a19156 100644 --- a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua +++ b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua @@ -48,6 +48,6 @@ end res, err = misc.sysprof.stop() assert(res, err) -test:ok(true, 'sysprof finished successfully') +test:ok(true, 'FFUNC frames were streamed correctly') os.exit(test:check() and 0 or 1) === On Wed, Nov 08, 2023 at 06:47:28PM +0300, Sergey Bronnikov wrote: > Hi, Max > > sorry for a delayed answer. > > LGTM with a minor comment > > > On 7/14/23 17:30, Maxim Kokryashkin wrote: > > > > > > > > > > +end > > > + > > > +res, err = misc.sysprof.stop() > > > +assert(res, err) > > > + > > > +test:ok(true, 'sysprof finished successfully') > > > I propose to reflect a goal of the test in a test description. Please add > something about ffunc to description. > > The test is not about whole sysprof, but about ffunc support in sysprof. > > > > + > > > +os.exit(test:check() and 0 or 1) > > > >