From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C8F9872FFD8; Tue, 12 Dec 2023 15:53:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C8F9872FFD8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1702385609; bh=/v7CkhJsgVn5Z3acjp5vx9KOXR/ZvFaGDq/Cgr/Z6qs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nO18Y1TM/O/H7cpStiBB2KJIEYH04/R1WlcGkn5UcPV7K+LxGA/1Art4gfnWuVTtF myTwwiV6Gx9T5/jFXg8xj22RAIxK26Pf0pphTulP9uAZhvBZK+EBP13+t6vREGbhOI p91rnir7uuCi/wUQR9/PaEcn3+WlH8vB/xLc5Np0= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [95.163.41.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E4FDD72FFD8 for ; Tue, 12 Dec 2023 15:53:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E4FDD72FFD8 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1rD2GN-002G6h-1M; Tue, 12 Dec 2023 15:53:27 +0300 Date: Tue, 12 Dec 2023 15:53:27 +0300 To: Sergey Kaplun Message-ID: References: <3d34441cd94210ab916527ce95c8cba0ef1b8f4f.1701888856.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD97533543916A0F71A68BC3DE160F347809BDBCA020D4EBE68CD62213F67905E7A783E4E187AE2DA0C23836ACD4600A35D9AA8FCFB4E4ECA502A808E2AF9A6ECDE X-C1DE0DAB: 0D63561A33F958A5579540F07C8AF39ADA0DCC45D2A64A0E39C64B3C927172EAF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0AD5177F0B940C8B66ECE892A7B2722663E91682638B966EB3F662256BEEFA9527F0BE68AE1DB36B49D46CA86A432D118F51A9F35459C5BF39B54D74E1A86786C70C67C1BA3A220291937FD76D11AF80A0D05D78792C5943AB3227DC3725D58CC8BEA455F16B58544A21C197AAF4D2E4732965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojm/AwjadTR3RP7iY+ZqfGPA== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407AF1C275283607AF4E0BF3468D4040E8E03F59D56C79CFAB3D51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/6] build: fix tool components handling X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed, branch is force-pushed. See the iterative diff below: On Tue, Dec 12, 2023 at 01:32:17PM +0300, Sergey Kaplun wrote: > Hi, Maxim! > Thanks for the patch! > Please, consider my comments below. > > On 06.12.23, Maxim Kokryashkin wrote: > > > > > diff --git a/Makefile.original b/Makefile.original > > index e67b6aa8..2a56d648 100644 > > --- a/Makefile.original > > +++ b/Makefile.original > > > > > @@ -95,7 +98,8 @@ FILES_JITLIB= bc.lua bcsave.lua dump.lua p.lua v.lua zone.lua \ > > dis_arm64be.lua dis_ppc.lua dis_mips.lua dis_mipsel.lua \ > > dis_mips64.lua dis_mips64el.lua vmdef.lua > > FILES_UTILSLIB= avl.lua bufread.lua symtab.lua > > -FILES_MEMPROFLIB= parse.lua humanize.lua > > +FILES_MEMPROFLIB= parse.lua humanize.lua process.lua > > Minor: Please use the aphabetic order here instead. > > > +FILES_SYSPROFLIB= parse.lua > > FILES_TOOLSLIB= memprof.lua > > I suppose we should include in `FILES_TOOLSLIB`. > > > > > ifeq (,$(findstring Windows,$(OS))) > > @@ -140,6 +144,7 @@ install: $(INSTALL_DEP) > > > > > diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt > > index 1dfc39e4..a4adc15b 100644 > > --- a/tools/CMakeLists.txt > > +++ b/tools/CMakeLists.txt > > === diff --git a/Makefile.original b/Makefile.original index 2a56d648..d0834fe6 100644 --- a/Makefile.original +++ b/Makefile.original @@ -98,9 +98,9 @@ FILES_JITLIB= bc.lua bcsave.lua dump.lua p.lua v.lua zone.lua \ dis_arm64be.lua dis_ppc.lua dis_mips.lua dis_mipsel.lua \ dis_mips64.lua dis_mips64el.lua vmdef.lua FILES_UTILSLIB= avl.lua bufread.lua symtab.lua -FILES_MEMPROFLIB= parse.lua humanize.lua process.lua +FILES_MEMPROFLIB= humanize.lua parse.lua process.lua FILES_SYSPROFLIB= parse.lua -FILES_TOOLSLIB= memprof.lua +FILES_TOOLSLIB= memprof.lua sysprof.lua ifeq (,$(findstring Windows,$(OS))) HOST_SYS:= $(shell uname -s) ===