From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8E814B021F3; Sun, 5 May 2024 15:40:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E814B021F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1714912827; bh=MRA5fhLRejUkETBSA+3kg4nnudItRnHYn0Wgo1Bnt0I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WcaXckxLwxqCcyei4zofOdRx12O8/b3YlQXRgt7xLybcz2kC5OIjOAJDBBPJERlaG MQbnWXvMWSIheYOaYqpO56gEaaMt4SHAHFYzg4pzSXqvacvP2grTMRYySXNE4bS4RE BmIP2orRgqMD2QvPYL8GxeEgqFbO7OGJC+GGfCnc= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D197BB021E8 for ; Sun, 5 May 2024 15:40:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D197BB021E8 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1s3bAG-000000034z3-194c; Sun, 05 May 2024 15:40:24 +0300 Date: Sun, 5 May 2024 15:40:23 +0300 To: Sergey Kaplun Message-ID: References: <400b3ae2c1454663c6d975b55a68db2621132cc1.1713773432.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <400b3ae2c1454663c6d975b55a68db2621132cc1.1713773432.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C1015E4FDF537780612B9BDA89275F00AF6777AB749340E2182A05F538085040B33AD3BEE458BFB3A6D5EE0DB6E1EC8D109AB71DCEC376E8A5E5CAF7D1578E23906DE0852CB239E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F9CBC1404CDFA5A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BB7F99EAEF16F19E48AD5523B9484D4B2438C396A0BB5DFCCC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CD56D36E97F3F038C302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3894DE5C3FF01FF54BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE73349F3DFB73D9B11731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5C6D993D033941DB35002B1117B3ED696E1A4202398591DF4C89B063BDC7FAC35823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBB57ADDF2FEC9A8CEA8CC571E6FD952678FDA5A042D23D59B688C4B4F08D42659901B20BD73D67EE643425263F8C9A4EB699FBA0EC74C2F6FB4D8C3F4A1D59C142E8EB5AC17E5F235F4332CA8FE04980913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3Gch4W13RDELl3upfHH8jg== X-Mailru-Sender: 00097D31F91C944BAED0411CFB052B9830C14F7C1EAD9798B951B70A5BD4BD8EA270A81B2E40782A21401CF93FD6FA5504C9FB44FCBCE9EE92D99EB8CC7091A7ECEABDC5717908DEF544888E8238EB4872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1 2/5] ci: add tablebump flavor for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for the single nit below. On Mon, Apr 22, 2024 at 11:49:55AM UTC, Sergey Kaplun wrote: > This flavor enables the LUAJIT_ENABLE_TABLE_BUMP option to test table > bump optimization. > > Needed for tarantool/tarantool#9924 > --- > .github/workflows/exotic-builds-testing.yml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml > index 859603bd..6ce100f4 100644 > --- a/.github/workflows/exotic-builds-testing.yml > +++ b/.github/workflows/exotic-builds-testing.yml > @@ -34,7 +34,7 @@ jobs: > BUILDTYPE: [Debug, Release] > ARCH: [ARM64, x86_64] > GC64: [ON, OFF] > - FLAVOR: [checkhook, dualnum, gdbjit, nojit, nounwind] > + FLAVOR: [checkhook, dualnum, gdbjit, nojit, nounwind, tablebump] > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > @@ -50,12 +50,20 @@ jobs: > FLAVORFLAGS: -DLUAJIT_USE_GDBJIT=ON > - FLAVOR: nounwind > FLAVORFLAGS: -DLUAJIT_NO_UNWIND=ON > + - FLAVOR: tablebump > + FLAVORFLAGS: -DLUAJIT_ENABLE_TABLE_BUMP=ON > exclude: > - ARCH: ARM64 > GC64: OFF > # DUALNUM is default for ARM64, no need for additional testing. > - FLAVOR: dualnum > ARCH: ARM64 > + # Within table bump optimization enabled (and due to our modification Typo: s/Within/With/ > + # related to metrics), some offsets in GG_State stop fit in 12bit > + # immediate. Hence, the build failed due to the DASM error > + # (DASM_S_RANGE_I). > + - FLAVOR: tablebump > + ARCH: ARM64 > runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}'] > name: > > LuaJIT ${{ matrix.FLAVOR }} > -- > 2.44.0 >