From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F07CB559602; Wed, 2 Aug 2023 11:18:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F07CB559602 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690964292; bh=UppTqjC4rXc9q47iUoulto2Aazu5qlM0mE21rhSFaZo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BIGHSl8qS6su/NEasuMIYQdUTo0J9pAWR7j6znC6lEmsVJtnXZlJN/FHOubbPXDB9 yDj3ecXMRipzEm8n52t4RYzKD3aLCqY3qJFVK9QZFNTB5wA6KzZCdDTXoQVkh9RpmO rFfnXVAua26Pgqs0hbBHkqtHL1Dwqh0aXd7a+uxY= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [95.163.41.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 497A9559602 for ; Wed, 2 Aug 2023 11:18:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 497A9559602 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1qR73Y-0029b5-0V; Wed, 02 Aug 2023 11:18:08 +0300 Date: Wed, 2 Aug 2023 11:18:07 +0300 To: Sergey Bronnikov Message-ID: References: <6535409abb0242a342285f683db945f54b01e5d2.1690915289.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6535409abb0242a342285f683db945f54b01e5d2.1690915289.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93761F2630DFFAF416DDF8A3A1F98730F81C7E6AA5A500726182A05F538085040776C08A6FC7E3D337DAB9CAA53839D06E5D4925115DFF4145D0A7FB595B139F3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D77100FFB2844417EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372521E7C1CE72986C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8786481F39DF7A0F771D0F7BE9F1DA9EF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520902A1BE408319B29C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB1593CA6EC85F86DB78CF848AE20165DD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3457EE4B4996FC5466E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C17119E5299B287EE2E808ACE2090B5E1725E5C173C3A84C332941D3B652364A4089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A54D17E8C37EC1126634469C4751CF4BA0D14640B0C5C926F4F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF8E1D1536C5913F82A7E45AC830116EECC89E902573142F004FF6609843ADBFA8D9E67331CBA3B6E48553022043D0BC9AF643D044ED8FBE72EF6707034256D6C8A74DFFEFA5DC0E7F02C26D483E81D6BE64ACE4A408B72B61B0CA6F94E606A667A52EF62A646584F811BD90D3D42C882D43082AE146A756F3 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojV0vAgLNnFucrbJvuXJsOZw== X-Mailru-Sender: 7940E2A4EB16C9974CFF14AB62FAC1506F99E919E18B5F1EA431DF6AD5B6610DE2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2 v2] ci: support coveralls X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a few nits regarding the commit message. Best regards, Maxim Kokryashkin On Tue, Aug 01, 2023 at 09:46:10PM +0300, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov > > The patch adds a workflow that runs regression test suites, produces a > summary about current code coverage and send code coverage data to Typo: s/about/of/ Typo: s/send code/sends code/ > Coveralls. Coveralls is a web-service that lets you inspect every detail Typo: s/web-service/web service/ > of your coverage. See Tarantool's LuaJIT page on Coveralls [1]. > > 1. https://coveralls.io/github/tarantool/luajit > --- > .github/actions/setup-linux/action.yml | 1 + > .github/workflows/coverage.yml | 60 ++++++++++++++++++++++++++ > 2 files changed, 61 insertions(+) > create mode 100644 .github/workflows/coverage.yml > > diff --git a/.github/actions/setup-linux/action.yml b/.github/actions/setup-linux/action.yml > index f0171b83..71619a60 100644 > --- a/.github/actions/setup-linux/action.yml > +++ b/.github/actions/setup-linux/action.yml > @@ -16,4 +16,5 @@ runs: > run: | > apt -y update > apt -y install cmake gcc make ninja-build perl > + pip3 install gcovr > shell: bash > diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml > new file mode 100644 > index 00000000..9fff06c7 > --- /dev/null > +++ b/.github/workflows/coverage.yml > @@ -0,0 +1,60 @@ > +name: Code coverage > + > +on: > + push: > + branches-ignore: > + - '**-notest' > + - 'upstream-**' > + tags-ignore: > + - '**' > + > +concurrency: > + # An update of a developer branch cancels the previously > + # scheduled workflow run for this branch. However, the default > + # branch, and long-term branch (tarantool/release/2.11, > + # tarantool/release/2.10, etc) workflow runs are never canceled. > + # > + # We use a trick here: define the concurrency group as 'workflow > + # run ID' + # 'workflow run attempt' because it is a unique > + # combination for any run. So it effectively discards grouping. > + # > + # XXX: we cannot use `github.sha` as a unique identifier because > + # pushing a tag may cancel a run that works on a branch push > + # event. > + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') > + && format('{0}-{1}', github.run_id, github.run_attempt) > + || format('{0}-{1}', github.workflow, github.ref) }} > + cancel-in-progress: true > + > +jobs: > + coverage: > + strategy: > + fail-fast: false > + runs-on: [self-hosted, regular, x86_64, Linux] > + steps: > + - uses: actions/checkout@v3 > + with: > + fetch-depth: 0 > + submodules: recursive > + - name: setup Linux > + uses: ./.github/actions/setup-linux > + - name: configure > + run: > > + cmake -S . -B ${{ env.BUILDDIR }} > + -G Ninja > + -DCMAKE_BUILD_TYPE=RelWithDebInfo > + -DLUAJIT_ENABLE_COVERAGE=ON > + -DLUAJIT_ENABLE_GC64=ON > + - name: build > + run: cmake --build . --parallel > + working-directory: ${{ env.BUILDDIR }} > + - name: test and generate code coverage report > + run: cmake --build ${{ env.BUILDDIR }} --parallel --target coverage > + - name: send code coverage to coveralls.io > + run: | > + curl -LO https://coveralls.io/coveralls-linux.tar.gz > + tar xvzf coveralls-linux.tar.gz > + ./coveralls -f ./coverage/luajit.xml > + working-directory: ${{ env.BUILDDIR }} > + env: > + COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} > -- > 2.34.1 >